2019-12-15 18:13:56 +00:00
|
|
|
import ./make-test-python.nix ({ pkgs, ... }: {
|
2019-01-23 09:19:23 +00:00
|
|
|
name = "overlayfs";
|
2021-01-10 19:08:30 +00:00
|
|
|
meta.maintainers = with pkgs.lib.maintainers; [ bachp ];
|
2019-01-23 09:19:23 +00:00
|
|
|
|
|
|
|
|
machine = { pkgs, ... }: {
|
|
|
|
|
virtualisation.emptyDiskImages = [ 512 ];
|
|
|
|
|
networking.hostId = "deadbeef";
|
|
|
|
|
environment.systemPackages = with pkgs; [ parted ];
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
testScript = ''
|
2019-12-15 18:13:56 +00:00
|
|
|
machine.succeed("ls /dev")
|
2019-01-23 09:19:23 +00:00
|
|
|
|
2019-12-15 18:13:56 +00:00
|
|
|
machine.succeed("mkdir -p /tmp/mnt")
|
2019-01-23 09:19:23 +00:00
|
|
|
|
|
|
|
|
# Test ext4 + overlayfs
|
2019-12-15 18:13:56 +00:00
|
|
|
machine.succeed(
|
|
|
|
|
"""
|
|
|
|
|
mkfs.ext4 -F -L overlay-ext4 /dev/vdb
|
|
|
|
|
mount -t ext4 /dev/vdb /tmp/mnt
|
|
|
|
|
mkdir -p /tmp/mnt/upper /tmp/mnt/lower /tmp/mnt/work /tmp/mnt/merged
|
|
|
|
|
# Setup some existing files
|
|
|
|
|
echo 'Replace' > /tmp/mnt/lower/replace.txt
|
|
|
|
|
echo 'Append' > /tmp/mnt/lower/append.txt
|
|
|
|
|
echo 'Overwrite' > /tmp/mnt/lower/overwrite.txt
|
|
|
|
|
mount -t overlay overlay -o lowerdir=/tmp/mnt/lower,upperdir=/tmp/mnt/upper,workdir=/tmp/mnt/work /tmp/mnt/merged
|
|
|
|
|
# Test new
|
|
|
|
|
echo 'New' > /tmp/mnt/merged/new.txt
|
nixos/tests/overlayfs: Fix erroneous backslashes
Since commit b7749c76715ba96727f7a12bc2514ddfa6847813, commands run as
part of VM tests are exiting immediately if an error happens.
When converting the overlayfs test to Python in commit
5ae92144ba04caefaf56b4204abe85b71dbb527b, the individual test commands
were crammed into one big string instead of using a series of test
commands like done in the Perl version.
Additionally, the backslash-escaped dollar signs were necessary in
Perl's double-quoted strings to avoid variable interpolation, for Python
however, this results in an actual backslash being inserted into the
command.
While this obviously results in an exit code of 1 (without an error
message, since it's using bash's expression evaluation command), the
test didn't fail because putting all these commands in one string will
result in only the last error code being relevant.
With the change to "set -e" for commands sent to test machines, this has
changed and with the exit code of all commands now relevant, the test
now fails because the errors from individual command substitutions that
were prevented by escaping the dollar sign are now actually visible.
This in turn also means that until now, we wouldn't have noticed if the
overlayfs test would have failed for real.
Signed-off-by: aszlig <aszlig@nix.build>
2021-06-16 02:30:26 +01:00
|
|
|
[[ "$(cat /tmp/mnt/merged/new.txt)" == "New" ]]
|
2019-12-15 18:13:56 +00:00
|
|
|
# Test replace
|
nixos/tests/overlayfs: Fix erroneous backslashes
Since commit b7749c76715ba96727f7a12bc2514ddfa6847813, commands run as
part of VM tests are exiting immediately if an error happens.
When converting the overlayfs test to Python in commit
5ae92144ba04caefaf56b4204abe85b71dbb527b, the individual test commands
were crammed into one big string instead of using a series of test
commands like done in the Perl version.
Additionally, the backslash-escaped dollar signs were necessary in
Perl's double-quoted strings to avoid variable interpolation, for Python
however, this results in an actual backslash being inserted into the
command.
While this obviously results in an exit code of 1 (without an error
message, since it's using bash's expression evaluation command), the
test didn't fail because putting all these commands in one string will
result in only the last error code being relevant.
With the change to "set -e" for commands sent to test machines, this has
changed and with the exit code of all commands now relevant, the test
now fails because the errors from individual command substitutions that
were prevented by escaping the dollar sign are now actually visible.
This in turn also means that until now, we wouldn't have noticed if the
overlayfs test would have failed for real.
Signed-off-by: aszlig <aszlig@nix.build>
2021-06-16 02:30:26 +01:00
|
|
|
[[ "$(cat /tmp/mnt/merged/replace.txt)" == "Replace" ]]
|
2019-12-15 18:13:56 +00:00
|
|
|
echo 'Replaced' > /tmp/mnt/merged/replace-tmp.txt
|
|
|
|
|
mv /tmp/mnt/merged/replace-tmp.txt /tmp/mnt/merged/replace.txt
|
nixos/tests/overlayfs: Fix erroneous backslashes
Since commit b7749c76715ba96727f7a12bc2514ddfa6847813, commands run as
part of VM tests are exiting immediately if an error happens.
When converting the overlayfs test to Python in commit
5ae92144ba04caefaf56b4204abe85b71dbb527b, the individual test commands
were crammed into one big string instead of using a series of test
commands like done in the Perl version.
Additionally, the backslash-escaped dollar signs were necessary in
Perl's double-quoted strings to avoid variable interpolation, for Python
however, this results in an actual backslash being inserted into the
command.
While this obviously results in an exit code of 1 (without an error
message, since it's using bash's expression evaluation command), the
test didn't fail because putting all these commands in one string will
result in only the last error code being relevant.
With the change to "set -e" for commands sent to test machines, this has
changed and with the exit code of all commands now relevant, the test
now fails because the errors from individual command substitutions that
were prevented by escaping the dollar sign are now actually visible.
This in turn also means that until now, we wouldn't have noticed if the
overlayfs test would have failed for real.
Signed-off-by: aszlig <aszlig@nix.build>
2021-06-16 02:30:26 +01:00
|
|
|
[[ "$(cat /tmp/mnt/merged/replace.txt)" == "Replaced" ]]
|
2019-12-15 18:13:56 +00:00
|
|
|
# Overwrite
|
nixos/tests/overlayfs: Fix erroneous backslashes
Since commit b7749c76715ba96727f7a12bc2514ddfa6847813, commands run as
part of VM tests are exiting immediately if an error happens.
When converting the overlayfs test to Python in commit
5ae92144ba04caefaf56b4204abe85b71dbb527b, the individual test commands
were crammed into one big string instead of using a series of test
commands like done in the Perl version.
Additionally, the backslash-escaped dollar signs were necessary in
Perl's double-quoted strings to avoid variable interpolation, for Python
however, this results in an actual backslash being inserted into the
command.
While this obviously results in an exit code of 1 (without an error
message, since it's using bash's expression evaluation command), the
test didn't fail because putting all these commands in one string will
result in only the last error code being relevant.
With the change to "set -e" for commands sent to test machines, this has
changed and with the exit code of all commands now relevant, the test
now fails because the errors from individual command substitutions that
were prevented by escaping the dollar sign are now actually visible.
This in turn also means that until now, we wouldn't have noticed if the
overlayfs test would have failed for real.
Signed-off-by: aszlig <aszlig@nix.build>
2021-06-16 02:30:26 +01:00
|
|
|
[[ "$(cat /tmp/mnt/merged/overwrite.txt)" == "Overwrite" ]]
|
2019-12-15 18:13:56 +00:00
|
|
|
echo 'Overwritten' > /tmp/mnt/merged/overwrite.txt
|
nixos/tests/overlayfs: Fix erroneous backslashes
Since commit b7749c76715ba96727f7a12bc2514ddfa6847813, commands run as
part of VM tests are exiting immediately if an error happens.
When converting the overlayfs test to Python in commit
5ae92144ba04caefaf56b4204abe85b71dbb527b, the individual test commands
were crammed into one big string instead of using a series of test
commands like done in the Perl version.
Additionally, the backslash-escaped dollar signs were necessary in
Perl's double-quoted strings to avoid variable interpolation, for Python
however, this results in an actual backslash being inserted into the
command.
While this obviously results in an exit code of 1 (without an error
message, since it's using bash's expression evaluation command), the
test didn't fail because putting all these commands in one string will
result in only the last error code being relevant.
With the change to "set -e" for commands sent to test machines, this has
changed and with the exit code of all commands now relevant, the test
now fails because the errors from individual command substitutions that
were prevented by escaping the dollar sign are now actually visible.
This in turn also means that until now, we wouldn't have noticed if the
overlayfs test would have failed for real.
Signed-off-by: aszlig <aszlig@nix.build>
2021-06-16 02:30:26 +01:00
|
|
|
[[ "$(cat /tmp/mnt/merged/overwrite.txt)" == "Overwritten" ]]
|
2019-12-15 18:13:56 +00:00
|
|
|
# Test append
|
nixos/tests/overlayfs: Fix erroneous backslashes
Since commit b7749c76715ba96727f7a12bc2514ddfa6847813, commands run as
part of VM tests are exiting immediately if an error happens.
When converting the overlayfs test to Python in commit
5ae92144ba04caefaf56b4204abe85b71dbb527b, the individual test commands
were crammed into one big string instead of using a series of test
commands like done in the Perl version.
Additionally, the backslash-escaped dollar signs were necessary in
Perl's double-quoted strings to avoid variable interpolation, for Python
however, this results in an actual backslash being inserted into the
command.
While this obviously results in an exit code of 1 (without an error
message, since it's using bash's expression evaluation command), the
test didn't fail because putting all these commands in one string will
result in only the last error code being relevant.
With the change to "set -e" for commands sent to test machines, this has
changed and with the exit code of all commands now relevant, the test
now fails because the errors from individual command substitutions that
were prevented by escaping the dollar sign are now actually visible.
This in turn also means that until now, we wouldn't have noticed if the
overlayfs test would have failed for real.
Signed-off-by: aszlig <aszlig@nix.build>
2021-06-16 02:30:26 +01:00
|
|
|
[[ "$(cat /tmp/mnt/merged/append.txt)" == "Append" ]]
|
2019-12-15 18:13:56 +00:00
|
|
|
echo 'ed' >> /tmp/mnt/merged/append.txt
|
|
|
|
|
#"cat /tmp/mnt/merged/append.txt && exit 1
|
nixos/tests/overlayfs: Fix erroneous backslashes
Since commit b7749c76715ba96727f7a12bc2514ddfa6847813, commands run as
part of VM tests are exiting immediately if an error happens.
When converting the overlayfs test to Python in commit
5ae92144ba04caefaf56b4204abe85b71dbb527b, the individual test commands
were crammed into one big string instead of using a series of test
commands like done in the Perl version.
Additionally, the backslash-escaped dollar signs were necessary in
Perl's double-quoted strings to avoid variable interpolation, for Python
however, this results in an actual backslash being inserted into the
command.
While this obviously results in an exit code of 1 (without an error
message, since it's using bash's expression evaluation command), the
test didn't fail because putting all these commands in one string will
result in only the last error code being relevant.
With the change to "set -e" for commands sent to test machines, this has
changed and with the exit code of all commands now relevant, the test
now fails because the errors from individual command substitutions that
were prevented by escaping the dollar sign are now actually visible.
This in turn also means that until now, we wouldn't have noticed if the
overlayfs test would have failed for real.
Signed-off-by: aszlig <aszlig@nix.build>
2021-06-16 02:30:26 +01:00
|
|
|
[[ "$(cat /tmp/mnt/merged/append.txt)" == "Append\ned" ]]
|
2019-12-15 18:13:56 +00:00
|
|
|
umount /tmp/mnt/merged
|
|
|
|
|
umount /tmp/mnt
|
|
|
|
|
udevadm settle
|
|
|
|
|
"""
|
|
|
|
|
)
|
2019-01-23 09:19:23 +00:00
|
|
|
'';
|
|
|
|
|
})
|
