alioth/nixpkgs
3
0
Fork 0
forked from mirrors/nixpkgs
Code Releases Activity
nixpkgs/pkgs/development/libraries/mesa/disk_cache-include-dri-driver-path-in-cache-key.patch

72 lines
2.5 KiB
Diff
Raw Normal View History

mesa: 18.2.2 -> 18.2.3 https://lists.freedesktop.org/archives/mesa-dev/2018-October/207343.html Optimistically drop disk cache patch, changelog mentions related changes to cache behavior. Not sure if those changes address our problem (can we count on build-id?) so someone more familiar with this should probably take a look before merging :).
2018-10-20 02:42:21 +01:00
From 2a1e32b4105fe95413a615a44d40938920ea1a19 Mon Sep 17 00:00:00 2001
mesa: add patch to include driver path in cache key Mesa usually uses the timestamps of the llvm and driver shared libraries as a cache key. In /nix/store these are all zero, so we'll include $(drivers) in the cache key, which should be unique for all combinations of mesa and llvm versions.
2018-08-06 20:23:02 +01:00
From: David McFarland <corngood@gmail.com>
Date: Mon, 6 Aug 2018 15:52:11 -0300
Subject: [PATCH] disk_cache: include dri driver path in cache key
This fixes invalid cache hits on NixOS where all shared library
timestamps in /nix/store are zero.
---
mesa: build with meson
2019-03-26 23:41:50 +00:00
meson_options.txt | 6 ++++++
mesa: add patch to include driver path in cache key Mesa usually uses the timestamps of the llvm and driver shared libraries as a cache key. In /nix/store these are all zero, so we'll include $(drivers) in the cache key, which should be unique for all combinations of mesa and llvm versions.
2018-08-06 20:23:02 +01:00
src/util/disk_cache.c | 3 +++
mesa: build with meson
2019-03-26 23:41:50 +00:00
src/util/meson.build | 7 ++++++-
3 files changed, 15 insertions(+), 1 deletion(-)
mesa: add patch to include driver path in cache key Mesa usually uses the timestamps of the llvm and driver shared libraries as a cache key. In /nix/store these are all zero, so we'll include $(drivers) in the cache key, which should be unique for all combinations of mesa and llvm versions.
2018-08-06 20:23:02 +01:00
mesa: build with meson
2019-03-26 23:41:50 +00:00
diff --git a/meson_options.txt b/meson_options.txt
index a723b5406cf..65a8954291f 100644
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -330,3 +330,9 @@ option(
value : true,
description : 'Enable direct rendering in GLX and EGL for DRI',
)
+option(
+ 'disk-cache-key',
+ type : 'string',
+ value : '',
+ description : 'Mesa cache key.'
+)
mesa: add patch to include driver path in cache key Mesa usually uses the timestamps of the llvm and driver shared libraries as a cache key. In /nix/store these are all zero, so we'll include $(drivers) in the cache key, which should be unique for all combinations of mesa and llvm versions.
2018-08-06 20:23:02 +01:00
diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c
mesa: build with meson
2019-03-26 23:41:50 +00:00
index 0aa2646a9bb..bd784d38e21 100644
mesa: add patch to include driver path in cache key Mesa usually uses the timestamps of the llvm and driver shared libraries as a cache key. In /nix/store these are all zero, so we'll include $(drivers) in the cache key, which should be unique for all combinations of mesa and llvm versions.
2018-08-06 20:23:02 +01:00
--- a/src/util/disk_cache.c
+++ b/src/util/disk_cache.c
mesa: build with meson
2019-03-26 23:41:50 +00:00
@@ -389,8 +389,10 @@ disk_cache_create(const char *gpu_name, const char *driver_id,
mesa: add patch to include driver path in cache key Mesa usually uses the timestamps of the llvm and driver shared libraries as a cache key. In /nix/store these are all zero, so we'll include $(drivers) in the cache key, which should be unique for all combinations of mesa and llvm versions.
2018-08-06 20:23:02 +01:00
/* Create driver id keys */
mesa: 18.2.2 -> 18.2.3 https://lists.freedesktop.org/archives/mesa-dev/2018-October/207343.html Optimistically drop disk cache patch, changelog mentions related changes to cache behavior. Not sure if those changes address our problem (can we count on build-id?) so someone more familiar with this should probably take a look before merging :).
2018-10-20 02:42:21 +01:00
size_t id_size = strlen(driver_id) + 1;
mesa: add patch to include driver path in cache key Mesa usually uses the timestamps of the llvm and driver shared libraries as a cache key. In /nix/store these are all zero, so we'll include $(drivers) in the cache key, which should be unique for all combinations of mesa and llvm versions.
2018-08-06 20:23:02 +01:00
+ size_t key_size = strlen(DISK_CACHE_KEY) + 1;
size_t gpu_name_size = strlen(gpu_name) + 1;
mesa: 18.2.2 -> 18.2.3 https://lists.freedesktop.org/archives/mesa-dev/2018-October/207343.html Optimistically drop disk cache patch, changelog mentions related changes to cache behavior. Not sure if those changes address our problem (can we count on build-id?) so someone more familiar with this should probably take a look before merging :).
2018-10-20 02:42:21 +01:00
cache->driver_keys_blob_size += id_size;
mesa: add patch to include driver path in cache key Mesa usually uses the timestamps of the llvm and driver shared libraries as a cache key. In /nix/store these are all zero, so we'll include $(drivers) in the cache key, which should be unique for all combinations of mesa and llvm versions.
2018-08-06 20:23:02 +01:00
+ cache->driver_keys_blob_size += key_size;
cache->driver_keys_blob_size += gpu_name_size;
/* We sometimes store entire structs that contains a pointers in the cache,
mesa: build with meson
2019-03-26 23:41:50 +00:00
@@ -411,6 +413,7 @@ disk_cache_create(const char *gpu_name, const char *driver_id,
mesa: add patch to include driver path in cache key Mesa usually uses the timestamps of the llvm and driver shared libraries as a cache key. In /nix/store these are all zero, so we'll include $(drivers) in the cache key, which should be unique for all combinations of mesa and llvm versions.
2018-08-06 20:23:02 +01:00
uint8_t *drv_key_blob = cache->driver_keys_blob;
DRV_KEY_CPY(drv_key_blob, &cache_version, cv_size)
mesa: 18.2.2 -> 18.2.3 https://lists.freedesktop.org/archives/mesa-dev/2018-October/207343.html Optimistically drop disk cache patch, changelog mentions related changes to cache behavior. Not sure if those changes address our problem (can we count on build-id?) so someone more familiar with this should probably take a look before merging :).
2018-10-20 02:42:21 +01:00
DRV_KEY_CPY(drv_key_blob, driver_id, id_size)
mesa: add patch to include driver path in cache key Mesa usually uses the timestamps of the llvm and driver shared libraries as a cache key. In /nix/store these are all zero, so we'll include $(drivers) in the cache key, which should be unique for all combinations of mesa and llvm versions.
2018-08-06 20:23:02 +01:00
+ DRV_KEY_CPY(drv_key_blob, DISK_CACHE_KEY, key_size)
DRV_KEY_CPY(drv_key_blob, gpu_name, gpu_name_size)
DRV_KEY_CPY(drv_key_blob, &ptr_size, ptr_size_size)
DRV_KEY_CPY(drv_key_blob, &driver_flags, driver_flags_size)
mesa: build with meson
2019-03-26 23:41:50 +00:00
diff --git a/src/util/meson.build b/src/util/meson.build
index 397c2228129..77013563e5d 100644
--- a/src/util/meson.build
+++ b/src/util/meson.build
@@ -120,7 +120,12 @@ libmesa_util = static_library(
[files_mesa_util, format_srgb],
include_directories : inc_common,
dependencies : [dep_zlib, dep_clock, dep_thread, dep_atomic, dep_m],
- c_args : [c_msvc_compat_args, c_vis_args],
+ c_args : [
+ c_msvc_compat_args, c_vis_args,
+ '-DDISK_CACHE_KEY="@0@"'.format(
+ get_option('disk-cache-key')
+ ),
+ ],
build_by_default : false
)
mesa: add patch to include driver path in cache key Mesa usually uses the timestamps of the llvm and driver shared libraries as a cache key. In /nix/store these are all zero, so we'll include $(drivers) in the cache key, which should be unique for all combinations of mesa and llvm versions.
2018-08-06 20:23:02 +01:00
--
mesa: build with meson
2019-03-26 23:41:50 +00:00
2.19.2
mesa: add patch to include driver path in cache key Mesa usually uses the timestamps of the llvm and driver shared libraries as a cache key. In /nix/store these are all zero, so we'll include $(drivers) in the cache key, which should be unique for all combinations of mesa and llvm versions.
2018-08-06 20:23:02 +01:00
Copy permalink